Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Include Date option in enterprise reporting configuration form #1407

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

omar-sarfraz
Copy link
Member

@omar-sarfraz omar-sarfraz commented Jan 31, 2025

Ticket: ENT-9945
Description: Added a checkbox in the reporting configuration page. It is used to enable / disable date suffix inclusion in the report's filename.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

image

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.44%. Comparing base (519feab) to head (a70b8a3).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...components/ReportingConfig/ReportingConfigForm.jsx 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1407   +/-   ##
=======================================
  Coverage   86.43%   86.44%           
=======================================
  Files         660      660           
  Lines       14926    14929    +3     
  Branches     3105     3160   +55     
=======================================
+ Hits        12902    12906    +4     
+ Misses       1955     1951    -4     
- Partials       69       72    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omar-sarfraz omar-sarfraz changed the title feat: Add Include Date option in reporting configuration form feat: Add Include Date option in enterprise reporting configuration form Feb 3, 2025
@omar-sarfraz omar-sarfraz force-pushed the osarfraz/ENT-9945 branch 3 times, most recently from cff2351 to 16ec59f Compare February 4, 2025 12:37
@omar-sarfraz omar-sarfraz merged commit a95d20f into openedx:master Feb 6, 2025
6 checks passed
@omar-sarfraz omar-sarfraz deleted the osarfraz/ENT-9945 branch February 6, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants